Skip to content

refactor(grid-list): remove unnecessary regex and cast to array #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2017
Merged

refactor(grid-list): remove unnecessary regex and cast to array #2502

merged 1 commit into from
Jan 18, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 3, 2017

  • Removes a regex that can be replaced by a faster indexOf check.
  • Removes an unnecessary cast from a QueryList to an Array.

@crisbeto
refactor(grid-list): remove unnecessary regex and cast to array
652b2e2 
* Removes a regex that can be replaced by a faster `indexOf` check.
* Removes an unnecessary cast from a QueryList to an Array.
@crisbeto crisbeto added the has pr label Jan 3, 2017
@crisbeto crisbeto requested a review from jelbourn January 3, 2017 07:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 3, 2017
@jelbourn jelbourn requested review from kara and removed request for jelbourn January 3, 2017 17:07
kara
kara approved these changes Jan 17, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 17, 2017
@kara kara removed their assignment Jan 17, 2017
@mmalerba mmalerba merged commit 29d9d59 into angular:master Jan 18, 2017
kara pushed a commit to kara/material2 that referenced this pull request Jan 20, 2017
@crisbeto @kara
refactor(grid-list): remove unnecessary regex and cast to array (angu…
64f7c17 
…lar#2502)

* Removes a regex that can be replaced by a faster `indexOf` check.
* Removes an unnecessary cast from a QueryList to an Array.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @kara @googlebot @mmalerba